pengfei accepted this revision. pengfei added a comment. This revision is now accepted and ready to land.
LGTM. ================ Comment at: llvm/lib/Target/X86/X86InstrInfo.td:3024 +// +let Predicates = [HasCMPCCXADD, In64BitMode], Defs = [EFLAGS], + Constraints = "$dstsrc2 = $dst" in { ---------------- skan wrote: > Should we set isCodeGenOnly =1 here? Should also set `mayLoad` and `mayStore`? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135933/new/ https://reviews.llvm.org/D135933 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits