AnkitDubeycs25 wrote:

Sorry for the long delay! I've addressed all the review comments:

Updated function signature to use CIRGenBuilderTy &builder, mlir::Location loc
Switched to mlir::ValueRange
Moved test to clang/test/CIR/CodeGenBuiltins/X86/ with proper RUN/CIR/LLVM/OGCG 
check lines
Fixed clang-format issues
Rebased onto latest main

@andykaylor @bcardosolopes please take another look!

https://github.com/llvm/llvm-project/pull/169648
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to