erichkeane wrote: > > No against reverting, but is the problem just missing a > > `-fclang-abi-compat=23`? I think it's also ok to commit a seperate patch > > for it. > > +1; I think a revert is fine to give breathing room but I think fixing it > forward to give an ABI compat flag is also fine if done quickly enough
I think we're OK with this too, we've convinced ourselves this gets us better in line with GCC here on every case, but this is obviously breaking behavior and thus needs the flag ASAP. It IS a bit unfortunate that this was merged without any of the CodeGen maintainers (@efriedma-quic and @asl ) being aware, as this is fairly knarly. > > This change broke several CIR ABI tests. > > Are there bots that should have reported that breakage? The only report that > I can see is for https://lab.llvm.org/buildbot/#/builders/190/builds/48978 No, unfortunately we don't yet have CIR build bots. We've been holding off on it, since we are 'close' to my criteria for 'build clangir by default', which would make ALL buildbots catch this :) https://github.com/llvm/llvm-project/pull/216777 _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
