On Wed, May 27, 2009 at 6:14 PM, Jeremy Moskovich <jer...@chromium.org>wrote:
> We also don't handle activation/deactivation of edit menu items correctly > (select all is always disabled). > That's http://crbug.com/8662. Standard commands (Copy/Paste/Select-all): > Your proposal sounds reasonable, but only if we do it for all platforms. Right now there's a lot of hard-coding done in the editor client that's Windows-only, and there are a lot of places where Windows has the same issues (e.g. activating/deactivating cut/copy/paste). > Emacs keyboard commands and IMEs: > > A possible solution to this would be to store a queue of the last N > NSEvents per renderer matched with an ID. the event would then be > serialized and sent to the renderer which could then send it's own IPC > message back to the browser process to get Cocoa to handle the message, we > could pick the NSEvent out of the queue by ID and send back the relevant > edit command to the renderer. > We already do much of this. Take a look at TabContentsViewMac::HandleKeyboardEvent, where ids referring to keyboard events not handled by WebKit are returned to the browser process. TabContentsViewMac then retrieves the original event and passes it up to Cocoa for handling. That might be an opportune time to Do The Right Thing. How do IMEs belong here? Avi --~--~---------~--~----~------------~-------~--~----~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~----------~----~----~----~------~----~------~--~---
