In all the cases so far, testing for OS_MACOSX first and then OS_POSIX
seems sufficient. I really don't like single flags that express
combinations of stuff.
--Amanda
On Wednesday, August 19, 2009, Mark Mentovai <m...@chromium.org> wrote:
>
> Ben Laurie wrote:
>> The observation is that many places that are currently:
>> #if defined(OS_LINUX)
>> are going to become:
>> #if defined(OS_LINUX) || defined(OS_FREEBSD)
>> and this is ugly.
>
> I think that these would generally be proper as defined(OS_POSIX) &&
> !defined(OS_MACOSX). If people think that's ugly, maybe we need a new
> macro that means the same thing. Maybe OS_UNIXISH.
>
> OS_MACOSX should not come out of OS_POSIX. Mac OS X is of course
> "Unixish" but I'm having a hard time coming up with a better macro
> name for what's being proposed here other than OS_POSIX_NOT_MACOSX.
>
> Mark
>
> >
>
--
"Portability is generally the result of advance planning rather than trench
warfare involving #ifdef" -- Henry Spencer (1992)
--~--~---------~--~----~------------~-------~--~----~
Chromium Developers mailing list: chromium-dev@googlegroups.com
View archives, change email options, or unsubscribe:
http://groups.google.com/group/chromium-dev
-~----------~----~----~----~------~----~------~--~---
