so, very strange! I am testing patch from BT294 and apparently even if with rgba-float and opengl output colorpicker volumes still slipped to 1.0 it provides much better darkened image with recovered highlights!
just with fader at 9 ... LIBGL_DRI3_DISABLE=1 vblank_mode=0 bin/cin I tried attached very simple xml with Andrea's test file AND my two other patches applying or reverting opengl3 patch seems to give much more resurrected image in ogl preview ... On Wed, Nov 8, 2023 at 8:55 PM Andrew Randrianasulu <[email protected]> wrote: > > indeed, with this mod Histogram can recovery highlights ... > but again, I have no idea if it can work ok with this mode turned on > all the time, so maybe make it preference or conditional on rgb(a) > float? > > On Wed, Nov 8, 2023 at 8:41 PM Andrew Randrianasulu > <[email protected]> wrote: > > > > or even like this, but histogram does not work sadly? > > > > will try to remove clamps from its code too, Like Andrea > > > > On Wed, Nov 8, 2023 at 8:26 PM Andrew Randrianasulu > > <[email protected]> wrote: > > > > > > with this HACK buffers can be overbright in X11/XV mode only, gl thrown > > > error! > > > > > > > > > On Wed, Nov 8, 2023 at 6:55 PM Andrew Randrianasulu > > > <[email protected]> wrote: > > > > > > > > On Wed, Nov 8, 2023 at 6:08 PM Andrew Randrianasulu > > > > <[email protected]> wrote: > > > > > > > > > > I tried cingg compiled on Nov, 1 2020 and issues still here - you > > > > > need native exr reader to see it with Andrea's sample. Either by > > > > > compositor's vectoroscope or color picker - in clipping case it will > > > > > show 1.0 for much of window area, in non-clipping mode (no plugins) > > > > > it will show up to 60.something in rgb channels! > > > > > > > > > > Sadly, 2018 version had no vectoroscope on compositor, need to > > > > > double-test if native exr reader + any plugin will fail there in the > > > > > same way via color picker..... > > > > > > > > so, may 6 2018 cingg exhibit same behavior on rgba-float tiff exported > > > > from cin-cv (because pure exr import somewhat not worked for me in > > > > this version). > > > > > > > > so, this is apparently not recent bug .....
diff --git a/cinelerra-5.1/cinelerra/vdevicex11.C b/cinelerra-5.1/cinelerra/vdevicex11.C index 24d1be0..6d87692 100644 --- a/cinelerra-5.1/cinelerra/vdevicex11.C +++ b/cinelerra-5.1/cinelerra/vdevicex11.C @@ -333,6 +333,13 @@ void VDeviceX11::new_output_buffer(VFrame **result, int file_colormodel, EDL *ed } break; + case BC_RGBA_FLOAT: + case BC_RGB_FLOAT: + if( device->out_config->driver == PLAYBACK_X11_GL + && !output->use_scrollbars ) + bitmap_type = BITMAP_PRIMARY; + break; + case BC_YUV420P: if( device->out_config->driver == PLAYBACK_X11_XV && window->accel_available(display_colormodel, 0) && diff --git a/cinelerra-5.1/guicast/bctexture.C b/cinelerra-5.1/guicast/bctexture.C index 52787e1..f1fd166 100644 --- a/cinelerra-5.1/guicast/bctexture.C +++ b/cinelerra-5.1/guicast/bctexture.C @@ -124,9 +124,9 @@ void BC_Texture::create_texture(int w, int h, int colormodel) glGenTextures(1, (GLuint*)&texture_id); glBindTexture(GL_TEXTURE_2D, (GLuint)texture_id); glEnable(GL_TEXTURE_2D); - int internal_format = texture_components == 4 ? GL_RGBA8 : GL_RGB8 ; + int internal_format = texture_components == 4 ? GL_RGBA32F : GL_RGB32F ; glTexImage2D(GL_TEXTURE_2D, 0, internal_format, texture_w, texture_h, - 0, GL_RGBA, GL_UNSIGNED_BYTE, 0); + 0, GL_RGBA, GL_FLOAT, 0); window_id = BC_WindowBase::get_synchronous()->current_window->get_id(); BC_WindowBase::get_synchronous()->put_texture(texture_id, texture_w, texture_h, texture_components);
<?xml version="1.0"?> <EDL VERSION=Infinity PATH=/dev/shm/try1.xml> <LOCALSESSION IN_POINT=-1 LOOP_PLAYBACK=0 LOOP_START=0 LOOP_END=0 OUT_POINT=-1 SELECTION_START=0 SELECTION_END=0 CLIP_TITLE=small_empty_room_1_4k.exr CLIP_ICON="" X_PANE=-1 Y_PANE=-1 TRACK_START0=0 VIEW_START0=0 TRACK_START1=0 VIEW_START1=0 TRACK_START2=0 VIEW_START2=0 TRACK_START3=0 VIEW_START3=0 ZOOM_SAMPLE=128 ZOOMY=512 ZOOM_ATRACK=32 ZOOM_VTRACK=32 PREVIEW_START=0 PREVIEW_END=-1 FLOATAUTO_TYPE=0 RED=9.803922e-02 GREEN=9.803922e-02 BLUE=9.803922e-02 RED_MAX=9.803922e-02 GREEN_MAX=9.803922e-02 BLUE_MAX=9.803922e-02 USE_MAX=0 GANG_TRACKS=0 AUTOGROUPTYPE_AUDIO_FADE_MIN=-81 AUTOGROUPTYPE_AUDIO_FADE_MAX=18 AUTOGROUPTYPE_VIDEO_FADE_MIN=0 AUTOGROUPTYPE_VIDEO_FADE_MAX=100 AUTOGROUPTYPE_ZOOM_MIN=1.000000e-03 AUTOGROUPTYPE_ZOOM_MAX=1.000000e-03 AUTOGROUPTYPE_SPEED_MIN=5.000000e-03 AUTOGROUPTYPE_SPEED_MAX=5.000000e-03 AUTOGROUPTYPE_X_MIN=-288 AUTOGROUPTYPE_X_MAX=144 AUTOGROUPTYPE_Y_MIN=-288 AUTOGROUPTYPE_Y_MAX=144> <CLIP_NOTES>Hello world</CLIP_NOTES> </LOCALSESSION> <SESSION ASSETLIST_FORMAT=1 ASSET_COLUMN0=100 ASSET_COLUMN1=100 SHOW_MUTE=0 SHOW_CAMERA_X=0 SHOW_CAMERA_Y=0 SHOW_CAMERA_Z=0 SHOW_PROJECTOR_X=0 SHOW_PROJECTOR_Y=0 SHOW_PROJECTOR_Z=0 SHOW_FADE=0 SHOW_PAN=0 SHOW_MODE=0 SHOW_MASK=0 SHOW_SPEED=0 SHOW_TRANSITIONS=1 SHOW_PLUGINS=0 SHOW_HARD_EDGES=1 AUTO_KEYFRAMES=0 SPAN_KEYFRAMES=1 AUTOS_FOLLOW_EDITS=1 BRENDER_START=0 BRENDER_END=0 EYEDROP_RADIUS=0 CROP_X1=0 CROP_Y1=0 CROP_X2=320 CROP_Y2=220 RULER_X1=0 RULER_Y1=0 RULER_X2=0 RULER_Y2=0 AWINDOW_FOLDER=1 CURSOR_ON_FRAMES=1 TYPELESS_KEYFRAMES=1 CWINDOW_DEST=0 CWINDOW_MASK=0 CWINDOW_METER=1 CWINDOW_OPERATION=7 CWINDOW_SCROLLBARS=0 CWINDOW_XSCROLL=0 CWINDOW_YSCROLL=-346 CWINDOW_ZOOM=0 CWINDOW_CLICK2PLAY=0 CWINDOW_CLEAR_COLOR=0 EDITING_MODE=1 FOLDERLIST_FORMAT=0 HIGHLIGHTED_TRACK=0 LABELS_FOLLOW_EDITS=1 PLUGINS_FOLLOW_EDITS=1 SINGLE_STANDALONE=1 PLAYBACK_PRELOAD=0 SAFE_REGIONS=0 SHOW_ASSETS=1 SHOW_TITLES=1 TEST_PLAYBACK_EDITS=1 TIME_FORMAT=1 TIMECODE_OFFSET=0 NUDGE_FORMAT=1 TOOL_WINDOW=1 VWINDOW_METER=0 VWINDOW_ZOOM=1 VWINDOW_CLICK2PLAY=0 DECODE_SUBTITLES=0 SUBTITLE_NUMBER=0 PROXY_BEEP=0 RENDER_BEEP=0></SESSION> <VIDEO INTERPOLATION_TYPE=0 INTERPOLATE_RAW=1 WHITE_BALANCE_RAW=1 COLORMODEL=RGBA-FLOAT INTERLACE_MODE=NOTINTERLACED CHANNELS=1 VCHANNEL_X_0=0 VCHANNEL_Y_0=0 FRAMERATE=10 FRAMES_PER_FOOT=16 OUTPUTW=4096 OUTPUTH=2048 ASPECTW=2 ASPECTH=1 PROXY_STATE=0 PROXY_SCALE=1 PROXY_DISABLED_SCALE=1 PROXY_USE_SCALER=0 PROXY_AUTO_SCALE=0></VIDEO> <AUDIO SAMPLERATE=44100 CHANNELS=2 ACHANNEL_ANGLE_0=180 ACHANNEL_ANGLE_1=0></AUDIO> <FOLDERS> </FOLDERS> <ASSETS> <ASSET SRC=/home/guest/small_empty_room_1_4k.exr> <FOLDER NUMBER=6></FOLDER> <FORMAT TYPE=EXR USE_HEADER=1 FFORMAT=mp4 FF_FORMAT_OPTIONS=""></FORMAT> <AUDIO_OMIT CHANNELS=0 RATE=0 BITS=0 BYTE_ORDER=0 SIGNED=0 HEADER=0 DITHER=0 AUDIO_LENGTH=0></AUDIO_OMIT> <VIDEO ACTUAL_HEIGHT=2048 ACTUAL_WIDTH=4096 HEIGHT=2048 WIDTH=4096 PROXY_SCALE=0 PROXY_EDL=0 LAYERS=1 PROGRAM=-1 FRAMERATE=10 VIDEO_LENGTH=-1 TIMECODE=-2 MOV_SPHERE=0 JPEG_SPHERE=0 SINGLE_FRAME=0 INTERLACE_MODE=NOTINTERLACED></VIDEO> </ASSET> </ASSETS> <MIXERS> </MIXERS> <LABELS> </LABELS> <TRACK RECORD=1 NUDGE=0 MIXER_ID=-1 PLAY=1 GANG=1 MASTER=1 DRAW=1 EXPAND=1 DATA_H=32 TRACK_W=4096 TRACK_H=2048 MASKS=255 TYPE=VIDEO> <TITLE>Video 1</TITLE> <EDITS> <EDIT STARTSOURCE=0 CHANNEL=0 LENGTH=30 HARD_LEFT=0 HARD_RIGHT=0 COLOR=0 GROUP_ID=0><FILE SRC=/home/guest/small_empty_room_1_4k.exr></FILE></EDIT> </EDITS> <MUTEAUTOS> <AUTO POSITION=0 VALUE=0></AUTO> </MUTEAUTOS> <CAMERA_X> <AUTO POSITION=0 VALUE=0 VALUE1=0 CONTROL_IN_VALUE=0 CONTROL_OUT_VALUE=0 TANGENT_MODE=3></AUTO> </CAMERA_X> <CAMERA_Y> <AUTO POSITION=0 VALUE=0 VALUE1=0 CONTROL_IN_VALUE=0 CONTROL_OUT_VALUE=0 TANGENT_MODE=3></AUTO> </CAMERA_Y> <CAMERA_Z> <AUTO POSITION=0 VALUE=1 VALUE1=0 CONTROL_IN_VALUE=0 CONTROL_OUT_VALUE=0 TANGENT_MODE=3></AUTO> </CAMERA_Z> <PROJECTOR_X> <AUTO POSITION=0 VALUE=0 VALUE1=0 CONTROL_IN_VALUE=0 CONTROL_OUT_VALUE=0 TANGENT_MODE=3></AUTO> </PROJECTOR_X> <PROJECTOR_Y> <AUTO POSITION=0 VALUE=0 VALUE1=0 CONTROL_IN_VALUE=0 CONTROL_OUT_VALUE=0 TANGENT_MODE=3></AUTO> </PROJECTOR_Y> <PROJECTOR_Z> <AUTO POSITION=0 VALUE=1 VALUE1=0 CONTROL_IN_VALUE=0 CONTROL_OUT_VALUE=0 TANGENT_MODE=3></AUTO> </PROJECTOR_Z> <FADEAUTOS> <AUTO POSITION=0 VALUE=10 VALUE1=0 CONTROL_IN_VALUE=0 CONTROL_OUT_VALUE=0 TANGENT_MODE=3></AUTO> </FADEAUTOS> <MODEAUTOS> <AUTO POSITION=0 VALUE=0></AUTO> </MODEAUTOS> <MASKAUTOS> <AUTO APPLY_BEFORE_PLUGINS=0 DISABLE_OPENGL_MASKING=0 POSITION=0> </AUTO> </MASKAUTOS> <SPEEDAUTOS> <AUTO POSITION=0 VALUE=1 VALUE1=0 CONTROL_IN_VALUE=0 CONTROL_OUT_VALUE=0 TANGENT_MODE=3></AUTO> </SPEEDAUTOS> </TRACK> </EDL>
-- Cin mailing list [email protected] https://lists.cinelerra-gg.org/mailman/listinfo/cin
