On Fri, 26 Jan 2024 23:08:25 GMT, Phil Race <p...@openjdk.org> wrote:

>> test/jdk/javax/swing/plaf/basic/BasicTextUI/8001470/bug8001470.java line 58:
>> 
>>> 56: 
>>> 57:                 textField1 = new JTextField("\u2588");
>>> 58:                 textField2 = new JTextField("\u2588");
>> 
>> You do not need to test the same character twice
>
> This isn't right. The test MUST use the Indic and Thai characters else the 
> test is pointless.
> The problem of them being unavailable in the font should be solved by using 
> Font.canDisplay(char)
> to find a font that DOES support them.
> If no font supports them, then it becomes a question of policy .. do you want 
> the test to silently pass
> or should the test fail because the system running this test really should 
> have those fonts.

Updated with font canDisplay check

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17528#discussion_r1485996650

Reply via email to