On Tue, 13 Feb 2024 04:26:06 GMT, Prasanta Sadhukhan <psadhuk...@openjdk.org> wrote:
> Actually there is a misunderstanding of this issue. The original issue > [JDK-8001470](https://bugs.openjdk.org/browse/JDK-8001470) fix caused > regression [JDK-8130892](https://bugs.openjdk.org/browse/JDK-8130892) which > caused regression [JDK-8160246](https://bugs.openjdk.org/browse/JDK-8160246) > which caused regression > [JDK-8226513](https://bugs.openjdk.org/browse/JDK-8226513) which caused > regression [JDK-8231084](https://bugs.openjdk.org/browse/JDK-8231084)(and > [JDK-8231336](https://bugs.openjdk.org/browse/JDK-8231336)) so 8001470 was > reverted back in https://hg.openjdk.org/jdk/jdk/rev/a4ecc45541da > > so ideally this test should be removed from the repo and PL and original > issue JDK-8001470 should be cloned, which I did at first but forgot to remove > this test and from PL.. As far as I can see, https://hg.openjdk.org/jdk/jdk/rev/a4ecc45541da#l1.16 brought back the original code that was added by JDK-8001470: https://hg.openjdk.org/jdk9/jdk9/jdk/rev/ff8622450b29#l1.14 The fix is not removed. The current code in the repo: https://github.com/openjdk/jdk/blob/618af397b4c636c89049f7398c14f37f0065df59/src/java.desktop/share/classes/javax/swing/plaf/basic/BasicTextUI.java#L945-L949 Compare it to the code after JDK-8001470: https://github.com/openjdk/jdk/blob/1c0f1c478fb6731eb1ca94683a0e9e432750c357/jdk/src/java.desktop/share/classes/javax/swing/plaf/basic/BasicTextUI.java#L942-L946 Can you spot a difference? So, the test is still relevant. After all, if the fix had been removed completely, this test would've failed all the time. But it doesn't. It fails only if there are no font to display the characters. Thus, I disagree with removing the test: the test ensures the bug in [JDK-8001470](https://bugs.openjdk.org/browse/JDK-8001470) does not reproduce. ------------- PR Comment: https://git.openjdk.org/jdk/pull/17528#issuecomment-1940997884
