On Mon, 11 Mar 2024 13:46:23 GMT, Alexey Ivanov <[email protected]> wrote:
>> Clean up five more tests.
>>
>> test/jdk/javax/swing/JDesktopPane/4132993/bug4132993.java
>> test/jdk/javax/swing/JDesktopPane/4773378/bug4773378.java
>> test/jdk/javax/swing/JEditorPane/4325606/bug4325606.java
>> test/jdk/javax/swing/JEditorPane/4330998/bug4330998.java
>> test/jdk/javax/swing/JEditorPane/4694598/FrameContent.html
>> test/jdk/javax/swing/JEditorPane/4694598/bug4694598.java
>
> test/jdk/javax/swing/JDesktopPane/4132993/bug4132993.java line 47:
>
>> 45: } catch (PropertyVetoException ex) {
>> 46: ex.printStackTrace();
>> 47: }
>
> Shouldn't the test fail if an unexpected exception is thrown?
It is not unexpected but instead of failing i think test should just pass.
Which will happen because the internal frame is not minimized so the test
condition is not recreated.
> test/jdk/javax/swing/JDesktopPane/4132993/bug4132993.java line 59:
>
>> 57: throw new RuntimeException("Test interrupted by "
>> 58: + e.getLocalizedMessage());
>> 59: }
>
> You can add `throws Exception` clause to the `main` method and remove this
> `catch` block.
Ok.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/18184#discussion_r1521066921
PR Review Comment: https://git.openjdk.org/jdk/pull/18184#discussion_r1521067257
