On Thu, 25 Jun 2026 14:46:24 GMT, Matthias Baesken <[email protected]> wrote:
> The IS_WIN2000 macro checks for Windows major version number >= 5, see > https://github.com/search?q=repo%3Aopenjdk%2Fjdk%20IS_WIN2000&type=code > but we run for a long time on much higher Windows versions as a minimum. > So the check is obsolete. > > --------- > - [x] I confirm that I make this contribution in accordance with the [OpenJDK > Interim AI Policy](https://openjdk.org/legal/ai). Changes requested by aivanov (Reviewer). src/java.desktop/windows/native/libawt/windows/awt.h line 161: > 159: * IS_WINVISTA returns TRUE on Vista > 160: */ > 161: #define IS_WINXP ((HIBYTE(LOWORD(::GetVersion())) >= 1) || > LOBYTE(LOWORD(::GetVersion())) > 5) This is wrong, you have to include the condition of IS_WIN2000 now. Windows XP is 5.1 (or any later version). Now the condition looks like `minor >= 1 || major > 5)`. ------------- PR Review: https://git.openjdk.org/jdk/pull/31676#pullrequestreview-4580064476 PR Review Comment: https://git.openjdk.org/jdk/pull/31676#discussion_r3481899372
