On Fri, 26 Jun 2026 14:34:29 GMT, Matthias Baesken <[email protected]> wrote:
>> src/java.desktop/windows/native/libawt/windows/awt.h line 161: >> >>> 159: * IS_WINVISTA returns TRUE on Vista >>> 160: */ >>> 161: #define IS_WINXP ((HIBYTE(LOWORD(::GetVersion())) >= 1) || >>> LOBYTE(LOWORD(::GetVersion())) > 5) >> >> IS_WINXP is now missing a check, no? >> >> Also, is there a reason to keep IS_WINXP and IS_WINVISTA? These are also >> older unsupported versions of Windows. > > We can probably kick them out too. > IS_WINXP is now missing a check, no? > Yes, it does as per [my comment above](https://github.com/openjdk/jdk/pull/31676#discussion_r3481899372). It should look like: IS_WINXP (((LOBYTE(LOWORD(::GetVersion())) >= 5) && (HIBYTE(LOWORD(::GetVersion())) >= 1) || LOBYTE(LOWORD(::GetVersion())) > 5) I may have missed or added a parenthesis. > Also, is there a reason to keep IS_WINXP and IS_WINVISTA? These are also > older unsupported versions of Windows. That's was the point of [my other comment](https://github.com/openjdk/jdk/pull/31676#issuecomment-4810315957), we can remove `IS_WINXP` too. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/31676#discussion_r3482146703
