On Thu, 25 Jun 2026 14:46:24 GMT, Matthias Baesken <[email protected]> wrote:
> The IS_WIN2000 macro checks for Windows major version number >= 5, see > https://github.com/search?q=repo%3Aopenjdk%2Fjdk%20IS_WIN2000&type=code > but we run for a long time on much higher Windows versions as a minimum. > So the check is obsolete. > > --------- > - [x] I confirm that I make this contribution in accordance with the [OpenJDK > Interim AI Policy](https://openjdk.org/legal/ai). src/java.desktop/windows/native/libawt/windows/awt.h line 161: > 159: * IS_WINVISTA returns TRUE on Vista > 160: */ > 161: #define IS_WINXP ((HIBYTE(LOWORD(::GetVersion())) >= 1) || > LOBYTE(LOWORD(::GetVersion())) > 5) IS_WINXP is now missing a check, no? Also, is there a reason to keep IS_WINXP and IS_WINVISTA? These are also older unsupported versions of Windows. src/java.desktop/windows/native/libawt/windows/awt_Toolkit.cpp line 2874: > 2872: } > 2873: } else { > 2874: swprintf(szVer + l, 128, L" (Windows 2000)"); Should still be "Unknown"? Taking a step back though, I'd argue this whole method should be deleted. It's only used in one log.fine statement in WToolkit, and the Windows version information that it is logging is unimportant enough that it hasn't been kept up to date since the start of the git history 19 years ago (probably longer). ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/31676#discussion_r3481618395 PR Review Comment: https://git.openjdk.org/jdk/pull/31676#discussion_r3481619361
