On Fri, 26 Jun 2026 13:17:18 GMT, Daniel Gredler <[email protected]> wrote:
>> The IS_WIN2000 macro checks for Windows major version number >= 5, see >> https://github.com/search?q=repo%3Aopenjdk%2Fjdk%20IS_WIN2000&type=code >> but we run for a long time on much higher Windows versions as a minimum. >> So the check is obsolete. >> >> --------- >> - [x] I confirm that I make this contribution in accordance with the >> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai). > > src/java.desktop/windows/native/libawt/windows/awt.h line 161: > >> 159: * IS_WINVISTA returns TRUE on Vista >> 160: */ >> 161: #define IS_WINXP ((HIBYTE(LOWORD(::GetVersion())) >= 1) || >> LOBYTE(LOWORD(::GetVersion())) > 5) > > IS_WINXP is now missing a check, no? > > Also, is there a reason to keep IS_WINXP and IS_WINVISTA? These are also > older unsupported versions of Windows. We can probably kick them out too. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/31676#discussion_r3482068818
