On Wed, 1 Jul 2026 15:15:52 GMT, Daniel Gredler <[email protected]> wrote:
>> We have at least 2 isXP() functions in the coding checking for very old >> Windows versions. These can be removed. >> >> --------- >> - [x] I confirm that I make this contribution in accordance with the >> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai). > > src/jdk.accessibility/windows/native/jabswitch/jabswitch.cpp line 444: > >> 442: error = modify(true); >> 443: if (error == 0) { >> 444: regEnable(); > > The check is "not XP", so this function call should be removed, no? Assuming > this is the case, please also check whether we call `regEnable` anywhere > else, it looks like we might be able to delete the whole function. > > (Caveat: I'm not very familiar with this jdk.accessibility module.) '!isXP())' means here exactly not XP or Win2000 because we test here 'osvi.dwMajorVersion == 5' ; so on Win10/11 'regEnable()' is executed. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/31725#discussion_r3510932636
