On Thu, 2 Jul 2026 14:38:56 GMT, Alexey Ivanov <[email protected]> wrote:
>> Matthias Baesken has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Do jabswitch.cpp change in another JBS issue
>
> src/java.desktop/windows/classes/sun/awt/windows/WPathGraphics.java line 332:
>
>> 330: } else {
>> 331: return true;
>> 332: }
>
> I'd use a direct `return`:
>
>
>
> return !(preferGDITextLayout ||
> FontUtilities.textLayoutIsCompatible(font));
>
>
> or after moving the logical negation into the parentheses
>
>
> return !preferGDITextLayout &&
> !FontUtilities.textLayoutIsCompatible(font);
>
>
> However, the current with the `if` statement is perhaps clearer.
Yeah it is a little bit clearer, so let's keep it this way !
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/31725#discussion_r3514329048
