On Thu, 2 Jul 2026 06:29:36 GMT, Matthias Baesken <[email protected]> wrote:
>> src/jdk.accessibility/windows/native/jabswitch/jabswitch.cpp line 444:
>>
>>> 442: error = modify(true);
>>> 443: if (error == 0) {
>>> 444: regEnable();
>>
>> The check is "not XP", so this function call should be removed, no? Assuming
>> this is the case, please also check whether we call `regEnable` anywhere
>> else, it looks like we might be able to delete the whole function.
>>
>> (Caveat: I'm not very familiar with this jdk.accessibility module.)
>
> '!isXP())' means here exactly 'not (XP or Win2000)' because we test here
> 'osvi.dwMajorVersion == 5' ; so on Win10/11 'regEnable()' is executed.
I propose moving out the changes to `jabswitch.cpp` into a separate issue, it
will be cleaner, taking into account `isXP` return different values in the two
modified files.
It looks like `regEnable` and `regDisable` need to be called to add Java Access
Bridge entry to Ease of Access Center.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/31725#discussion_r3513875223
