On Tue, 30 Jun 2026 13:26:46 GMT, Matthias Baesken <[email protected]> wrote:

> We have at least 2 isXP() functions in the coding checking for very old 
> Windows versions. These can be removed.
> 
> ---------
> - [x] I confirm that I make this contribution in accordance with the [OpenJDK 
> Interim AI Policy](https://openjdk.org/legal/ai).

src/java.desktop/windows/classes/sun/awt/windows/WPathGraphics.java line 332:

> 330:             } else {
> 331:                 return true;
> 332:             }

I'd use a direct `return`:



            return !(preferGDITextLayout || 
FontUtilities.textLayoutIsCompatible(font));


or after moving the logical negation into the parentheses


            return !preferGDITextLayout && 
!FontUtilities.textLayoutIsCompatible(font);


However, the current with the `if` statement is perhaps clearer.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/31725#discussion_r3513907593

Reply via email to