On Wed, 29 Jul 2026 07:35:09 GMT, Matthias Baesken <[email protected]> wrote:

>> src/java.desktop/windows/native/libawt/java2d/d3d/D3DPipelineManager.cpp 
>> line 408:
>> 
>>> 406:         } else {
>>> 407:             J2dRlsTrace(J2D_TRACE_INFO,"OS_UNKNOWN: GetVersionEx 
>>> failed\n");
>>> 408:             currentOS = OS_UNKNOWN;
>> 
>> Windows 10 and Windows 11 are mapped to OS_UNKNOWN? it does not seems to be 
>> correct, since that will skip all checks for OS_ALL. Same question for 
>> OS_WINSERV_2008R2 and above.
>
> Yes, as it is Win10/Win11 are mapped to OS_UNKNOWN; maybe we have to change 
> this (previously Win10/11 were detected as OS_VISTA).
> OS_WINSERV_2008R2 is mapped to OS_WINSERV_2008R2 so this is handled.
> 
> Regarding the checks for OS_ALL, not sure how important they are those days. 
> Those graphics card checks look rather outdated, some will most likely not 
> even work with Win10/11 (but probably this needs a bit more checking).

The check for "Microsoft Basic Render Driver" is an important one, not sure 
about others like "All Intel Chips".

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/32011#discussion_r3676563784

Reply via email to