On Wed, 29 Jul 2026 17:17:36 GMT, Sergey Bylokhov <[email protected]> wrote:
>> Yes, as it is Win10/Win11 are mapped to OS_UNKNOWN; maybe we have to change >> this (previously Win10/11 were detected as OS_VISTA). >> OS_WINSERV_2008R2 is mapped to OS_WINSERV_2008R2 so this is handled. >> >> Regarding the checks for OS_ALL, not sure how important they are those days. >> Those graphics card checks look rather outdated, some will most likely not >> even work with Win10/11 (but probably this needs a bit more checking). > > The check for "Microsoft Basic Render Driver" is an important one, not sure > about others like "All Intel Chips". I could keep the OS_VISTA and add a comment that it matches also Win10/11. Or add new macros for Win10/11 and Win Server 2012+. What would you prefer? ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/32011#discussion_r3680842396
