On Wed, 2 Sep 2026 13:19:39 GMT, Matthias Baesken <[email protected]> wrote:

>> sun/awt/OSInfo.java contains very old Windows versions like Windows 95,98, 
>> ME. Those can be removed.
>> 
>> ---------
>> - [x] I confirm that I make this contribution in accordance with the 
>> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai).
>
> Matthias Baesken has updated the pull request incrementally with one 
> additional commit since the last revision:
> 
>   WindowsLookAndFeel.isOnVista remove more calls

src/java.desktop/windows/classes/com/sun/java/swing/plaf/windows/WindowsLookAndFeel.java
 line 588:

> 586: 
> 587:         if (!(this instanceof WindowsClassicLookAndFeel) &&
> 588:                 (OSInfo.getOSType() == OSInfo.OSType.WINDOWS)) {

We are here in Windows-only code 
(src/java.desktop/**windows**/classes/com/sun/java/swing/plaf/windows/WindowsLookAndFeel.java)
so checking for OS type Windows is probably redundant ?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/32419#discussion_r3914857363

Reply via email to