On Wed, 2 Sep 2026 13:55:55 GMT, Matthias Baesken <[email protected]> wrote:
>> Matthias Baesken has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> WindowsLookAndFeel.isOnVista remove more calls
>
> src/java.desktop/windows/classes/com/sun/java/swing/plaf/windows/WindowsLookAndFeel.java
> line 588:
>
>> 586:
>> 587: if (!(this instanceof WindowsClassicLookAndFeel) &&
>> 588: (OSInfo.getOSType() == OSInfo.OSType.WINDOWS)) {
>
> We are here in Windows-only code
> (src/java.desktop/**windows**/classes/com/sun/java/swing/plaf/windows/WindowsLookAndFeel.java)
> so checking for OS type Windows is probably redundant ?
Some Windows L&F classes were previously available on Linux. If
`WindowsLookAndFeel` class is now included on Windows only, this condition for
being on Windows is redundant and can be removed.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/32419#discussion_r3993086801
