On 2013-03-26 13:05, Rolf Eike Beer wrote:
Brad King wrote:
@@ -190,6 +198,8 @@
  # (To distribute this file outside of CMake, substitute the full
  #  License text for the above reference.)

+include(CMakeParseArguments)
+
  function (__java_copy_file src dest comment)
      add_custom_command(
          OUTPUT  ${dest}

This should probably be
include(${CMAKE_CURRENT_LIST_DIR}/CMakeParseArguments.cmake) to avoid issues
with peoples having copies of that module lying around somewhere like we do it
for FPHSA.

...or 'include("${CMAKE_ROOT}/Modules/CMakeParseArguments.cmake")'?

*Most* of the find modules appear to use CMAKE_CURRENT_LIST_DIR, but there are some (not necessarily find-package) modules that use CMAKE_ROOT, and some (mostly non-find) that rely on CMAKE_MODULE_PATH.

Which is best?

--
Matthew

--

Powered by www.kitware.com

Visit other Kitware open-source projects at 
http://www.kitware.com/opensource/opensource.html

Please keep messages on-topic and check the CMake FAQ at: 
http://www.cmake.org/Wiki/CMake_FAQ

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/cgi-bin/mailman/listinfo/cmake-developers

Reply via email to