----- Original Message ----- > On 10/04/2014 11:37 AM, Adam Strzelecki wrote: > > I've applied your suggestions about quoting and used portable > > (POSIX compliant) find call that should work now on any system. > > Thanks. > > On 10/05/2014 03:35 PM, Adam Strzelecki wrote: > > Correct me if I am wrong but it seems CDash reports no > > further problems with my changes. > > It's better, but the BundleUtilities test fails on OS X 10.5: > > http://open.cdash.org/testDetails.php?test=285651145&build=3517533 > > -- 6/10: fixing up > > '.../Tests/BundleUtilities/testdir1/testbundleutils1.app/Contents/MacOS/testbundleutils1' > install_name_tool: more than one input file specified > (.../Tests/BundleUtilities/testdir1 and -delete_rpath) > Usage: install_name_tool [-change old new] ... [-id name] input > -- 7/10: fixing up > > '.../Tests/BundleUtilities/testdir1/testbundleutils1.app/Contents/MacOS/module1.so' > install_name_tool: more than one input file specified > (.../Tests/BundleUtilities/testdir1 and -delete_rpath) > Usage: install_name_tool [-change old new] ... [-id name] input > > From this message it looks like the install_name_tool does not > support -delete_rpath. IIRC @rpath was first added in OS X 10.5 > so it looks like that part had not yet matured. > > Use of -delete_rpath was previously added at install-time here: > > OS X: Add RPATH support for Mac. > http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=94e7fef2 > > so I think this problem existed before but was not exposed by tests. > > Clinton, what do you think of changing the Darwin.cmake test for > enabling @rpath support to require OS X 10.6 instead of 10.5? > Otherwise we may be leaking build tree RPATH entries into installed > files on 10.5.
Sure, I think it would be good to require 10.6. We also have uses of the -delete_rpath/-add_rpath parameters in cmInstallTargetGenerator.cxx, and the test of that already requires 10.6 or greater. Clint -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/cmake-developers
