On Wednesday, October 08, 2014 11:17:03 AM Brad King wrote: > On 10/08/2014 11:05 AM, [email protected] wrote: > > I pushed more fixes for this. Instead of requiring 10.6, > > I took the other path of warning when rpaths need changed > > at install time and skip it. > > This should also fix the CMP0042 test which started failing. > > Thanks. The message is currently: > > + msg << "WARNING: Target \"" << this->Target->GetName() > > + << "\" has runtime paths which cannot be changed during install. > > " + << "To change runtime paths, OS X version 10.6 or newer is > > required. " + << "Therefore, runtime paths will not be changed > > when installing."; + cmSystemTools::Message(msg.str().c_str(), > > "Warning"); > > Can that be changed to an IssueMessage, possibly on a cmMakefile > for at least a little context? Also it should suggest using > CMAKE_BUILD_WITH_INSTALL_RPATH.
Fixed. > > > By the way, Brad, your change to require 10.6 for the > > BundleUtilities test is no longer required on the rpath-osx-10_6 topic. > > I thought it was a missing piece of your original change. > Since you've reverted that I've now reverted mine so we'll > see how testing goes. Yeah. I'm curious if changes to BundleUtilities.cmake in fix-OSX-bundle- rpaths-and-Qt5 will gracefully handle the BundleUtilities test case with @rpath on OS X 10.5. Perhaps it'll recognize there is no need to change rpaths. Clint -- Powered by www.kitware.com Please keep messages on-topic and check the CMake FAQ at: http://www.cmake.org/Wiki/CMake_FAQ Kitware offers various services to support the CMake community. For more information on each offering, please visit: CMake Support: http://cmake.org/cmake/help/support.html CMake Consulting: http://cmake.org/cmake/help/consulting.html CMake Training Courses: http://cmake.org/cmake/help/training.html Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html Follow this link to subscribe/unsubscribe: http://public.kitware.com/mailman/listinfo/cmake-developers
