----- Original Message -----
>
> ----- Original Message -----
> > On 10/06/2014 10:36 AM, Adam Strzelecki wrote:
> > >> Sure, I think it would be good to require 10.6.
> > >
> > > Moreover I believe nobody nowadays builds for 10.5 on 10.5.
> >
> > Perhaps no one has to build that way for deployment but there could
> > still be people just building for their own host as the only computer
> > they have. The fact that our dashboard reported this problem means
> > we are testing that case.
> >
> > Clinton, I don't have a 10.5 machine anymore and the test is failing
> > on yours. Please take whatever action you feel is appropriate to
> > resolve the test failure on that machine. This could mean either
> > disabling rpath altogether on 10.5 or changing the new hunk:
> >
> > > + foreach(rpath ${${ikey}_RPATHS})
> > > + set(changes ${changes} -delete_rpath "${rpath}")
> > > + endforeach()
> >
> > to warn and skip removal when hosted on 10.5. Or another option you
> > find.
> >
> > This needs to be resolved in the next day or two or the topic won't
> > be in CMake 3.1.
> >
> > Thanks,
> > -Brad
> >
> >
>
> I don't have a 10.5 machine, but I've put in a commit which I hope solves the
> problem.
> 36c509b9 OSX: Only enable @rpath support on OS X 10.6 or greater.
>
I pushed more fixes for this. Instead of requiring 10.6, I took the other path
of warning when rpaths need changed at install time and skip it.
This should also fix the CMP0042 test which started failing.
By the way, Brad, your change to require 10.6 for the BundleUtilities test is
no longer required on the rpath-osx-10_6 topic.
However, it may still be required for the fix-OSX-bundle-rpaths-and-Qt5 topic.
Clint
--
Powered by www.kitware.com
Please keep messages on-topic and check the CMake FAQ at:
http://www.cmake.org/Wiki/CMake_FAQ
Kitware offers various services to support the CMake community. For more
information on each offering, please visit:
CMake Support: http://cmake.org/cmake/help/support.html
CMake Consulting: http://cmake.org/cmake/help/consulting.html
CMake Training Courses: http://cmake.org/cmake/help/training.html
Visit other Kitware open-source projects at
http://www.kitware.com/opensource/opensource.html
Follow this link to subscribe/unsubscribe:
http://public.kitware.com/mailman/listinfo/cmake-developers
