eladkal commented on code in PR #28744:
URL: https://github.com/apache/airflow/pull/28744#discussion_r1062441112


##########
airflow/providers/exasol/operators/exasol.py:
##########
@@ -17,12 +17,15 @@
 # under the License.
 from __future__ import annotations
 
-import warnings
 from typing import Sequence
 
 from airflow.providers.common.sql.operators.sql import SQLExecuteQueryOperator
 
 
+def exasol_fetch_all_handler(cursor) -> list[tuple] | None:
+    return cursor.fetchall()

Review Comment:
   I think this function should be in exasol hook rather than the operator?
   
   BTW is this specific to exasol or may applied to other integrations ? if so 
maybe this needs to be in common.sql ?
   
   
   I wonder what happens if using `SqlSensor` with exasol?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to