potiuk commented on code in PR #28744:
URL: https://github.com/apache/airflow/pull/28744#discussion_r1063331317


##########
airflow/providers/exasol/operators/exasol.py:
##########
@@ -17,12 +17,15 @@
 # under the License.
 from __future__ import annotations
 
-import warnings
 from typing import Sequence
 
 from airflow.providers.common.sql.operators.sql import SQLExecuteQueryOperator
 
 
+def exasol_fetch_all_handler(cursor) -> list[tuple] | None:
+    return cursor.fetchall()

Review Comment:
   > As far as I know at least Presto not implements all mandatory properties, 
for example 
[presto-python-client](https://github.com/prestodb/presto-python-client/blob/57b95549650aad5a647a768472bf6909320f1bf3/prestodb/dbapi.py#L37-L40)
 not implements [paramstyle](https://peps.python.org/pep-0249/#paramstyle) but 
for this case we manually set this value in 
[Hook](https://github.com/apache/airflow/blob/8290ade26deba02ca6cf3d8254981b31cf89ee5b/airflow/providers/presto/hooks/presto.py#L83)
 but technically we could get this value from DB-API compliant libraries.
   
   I do not think this is a problem - we only really should care about the 
non-compliance if we are depending on it in our code - otherwise, it's up to 
the user to know that Presto is not fully db-api-2 compliant. In case of 
exasol, the root cause was that it does not set the ".description" property 
which we used to determine if we should fetch results or not, and I believe we 
have not used `paramstyle` in our "common.sql" code.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to