potiuk commented on code in PR #28744: URL: https://github.com/apache/airflow/pull/28744#discussion_r1063311864
########## airflow/providers/exasol/operators/exasol.py: ########## @@ -17,12 +17,15 @@ # under the License. from __future__ import annotations -import warnings from typing import Sequence from airflow.providers.common.sql.operators.sql import SQLExecuteQueryOperator +def exasol_fetch_all_handler(cursor) -> list[tuple] | None: + return cursor.fetchall() Review Comment: Re: applying to others: Moving it now to common.sql though is an extra complication - because then it means that you can only rely on version >= 1.4.0 (?) for exasol. If there are other reasons to do it, we could make it "common" but if we do not need it now, we can leave it in exasol and move it to common when needed. There is this nice saying "You have to make something usable first in order to make it reusable". -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
