potiuk commented on code in PR #28744: URL: https://github.com/apache/airflow/pull/28744#discussion_r1063338954
########## airflow/providers/exasol/operators/exasol.py: ########## @@ -17,12 +17,15 @@ # under the License. from __future__ import annotations -import warnings from typing import Sequence from airflow.providers.common.sql.operators.sql import SQLExecuteQueryOperator +def exasol_fetch_all_handler(cursor) -> list[tuple] | None: + return cursor.fetchall() Review Comment: And anotther BTW. I think with this change, it's actually great verification that the common sql extraction of @kazanzhy works nicely, following the [open-closed](https://en.wikipedia.org/wiki/Open%E2%80%93closed_principle) principles. It turned out that we can implement exasol-specific behaviour without modifying the "common.sql" code which is precisely what "open for extensions and closed for modifications" is about. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
