o-nikolas commented on code in PR #29245:
URL: https://github.com/apache/airflow/pull/29245#discussion_r1092353835
##########
airflow/providers/amazon/aws/operators/sagemaker.py:
##########
@@ -679,11 +697,11 @@ def __init__(
self.check_interval = check_interval
self.max_ingestion_time = max_ingestion_time
self.check_if_job_exists = check_if_job_exists
- if action_if_job_exists in ("increment", "fail"):
+ if action_if_job_exists in {"random", "increment", "fail"}:
Review Comment:
These will cause the jobs to have different names from now onward, ya? I
think @ferruzzi modified this code somewhat recently and we tried to keep the
naming the same for backwards compatibility (folks may have other logic that
depends on the names being in the format they have been historically).
How to handle these low level breaking changes has been a hot topic lately
in Airflow, I still don't think we've landed on a spot everyone agrees with.
Thoughts?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
