potiuk commented on PR #22253: URL: https://github.com/apache/airflow/pull/22253#issuecomment-1890392275
> Side note @potiuk: this is where I do not like "unresolved conversations". They are hiding in outdated changes :/ @bolkedebruin - you just gave the most important reason why enabling "requiring resolving conversation" is useful. Those unresolved conversations are STILL there. Does not matter if you we have "require resolving conversation" enabled. And you might have MISSED that there are unresolved conversation. By requiring them to be resolved, yes - you have to do few more clicks to find them, read and resolve. Which is PRECISELY the point. It forces SOMEONE to actually check and do some action to resolve the conversations to merge the PR. You migh not like having to do it yourself, but it is good for the project as a whole (and for you as well) because some important points from teh conversation could have been missed. I will actually add this comment to my list of positive effects that I am gatherting to present at the end of the trial. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
