potiuk commented on PR #22253: URL: https://github.com/apache/airflow/pull/22253#issuecomment-1890484550
I simply thinnk that individual "little" time on reviewing the comments and resolving them is very little price to pay for "project" positive effect of making sure we have not forgotten everything. The value for project trumps (small) inconvenience for individual. I personally review and merge maybe 80 PRs a week. And I still do not see an inconvenience of resolving such unresolved comments. I just find it super-strange that someone finds it inconvenient to do it for few PRs they are seeing and iterating over during the week. Somehow I cannot believe it's that big of an overhead. And yes this case. is a BIT of an outlier because it accumulated some historical conversation that were not resolved "on the spot" - but hopefully, if we agree to get the conversattion requirement to go ahead, this will be less and less of a problem as people will get used to resolving conversations when they are well, resolved. Yes. That asks for change in an individual habits and behaviours. But I strongly belive the small inconvenience are nothing comparing with the "pause and think before merging and make sure what you are merging had not missed important comment" for the project. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
