bolkedebruin commented on PR #22253: URL: https://github.com/apache/airflow/pull/22253#issuecomment-1890482790
I'm of the opposite opinion here @potiuk . I understand why you would like to have it, I do not support it though as I think it a administrative waste tbh. Trust the authors and contributors to do the right thing rather than put this into technology. I have not seen your argument backed up by facts on the amount of PRs merged vs errors we have made while merging them. That is my biggest concern with adding this kind of administrative overhead. It seems to be a solution in search of a problem. This PR started over one and a half year ago. Its remarks are tied to that timeline. The world has progressed. The remarks were not surfaced by Github and still needed to be resolved while being irrelevant. The risk that this generates is that committers will start looking at the conversations and just click "resolve" without reading to get past the administrative part. > Which is PRECISELY the point. It forces SOMEONE to actually check and do some action to resolve the conversations to merge the PR. No it wasn't. The point is to prevent errors while merging. The means that is experimented with now is to accomplish that by forcing resolution by clicking "resolve". So your welcome to list it as a positive, I will list it as a negative :-). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
