potiuk commented on PR #22253: URL: https://github.com/apache/airflow/pull/22253#issuecomment-1891065228
@vsoch :) -> yep I know what you talk about, but I think in this case there is reverse cause <> effect. What we are discussing here (ned to resolve comments to merge PR) is just causing problems when PR runs long, but I think it has little chance of causing it in the first place IMHO. The experiment here is to see the results of experiment where we enabled "require conversation resolving" to merge PR. We enabled it 2 weeks ago and the problem is that this PR has been opened a long time ago, so what @bolkedebruin is complaining here is that he had to go back and solve a number of old and stale conversations here - but the root cause was really that it had some outstanding changes and tests that were solved just a few days ago (and it took few minutes for @bolkedebruin - I guess - to resolve all the conversations that were outstanding (even if old) after the tests passed and comments were addressed. So I would not really connect your past experience then and the discussion we have :D -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
