Taragolis commented on code in PR #37545:
URL: https://github.com/apache/airflow/pull/37545#discussion_r1494864956
##########
airflow/settings.py:
##########
@@ -27,7 +27,7 @@
from typing import TYPE_CHECKING, Any, Callable
import pluggy
-from sqlalchemy import create_engine, exc, text
+from sqlalchemy import __version__ as sqlalchemy_version, create_engine, exc,
text
Review Comment:
No I mean a bit different, e.g. get from distribution package, but we do not
discuss preferable way
```python
import sys
if sys.version_info >= (3, 9):
from importlib.metadata import version
else:
from importlib_metadata import version
SQL_ALCHEMY_V1 = version("sqlalchemy").startswith("1")
```
> But then saw the PENDULUM3 example and amended my code.
Pendulum3 I guess exists only in tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
