Dev-iL commented on code in PR #37545: URL: https://github.com/apache/airflow/pull/37545#discussion_r1494895941
########## airflow/settings.py: ########## @@ -27,7 +27,7 @@ from typing import TYPE_CHECKING, Any, Callable import pluggy -from sqlalchemy import create_engine, exc, text +from sqlalchemy import __version__ as sqlalchemy_version, create_engine, exc, text Review Comment: 1. [Not only in tests](https://github.com/apache/airflow/blob/016892b7d6bc654ac3ff7e4f8f9f7231f835bed7/airflow/utils/timezone.py#L32). 2. Importlib metadata was [added in py3.8,](https://docs.python.org/3/library/importlib.metadata.html) which is the minimum aupported in airflow anyway, so no need to do any fancy checking. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
