vincbeck commented on code in PR #45562:
URL: https://github.com/apache/airflow/pull/45562#discussion_r1925735076
##########
task_sdk/src/airflow/sdk/definitions/asset/__init__.py:
##########
@@ -257,6 +258,17 @@ def iter_dag_dependencies(self, *, source: str, target:
str) -> Iterator[DagDepe
raise NotImplementedError
+@attrs.define(frozen=True)
+class AssetWatcher:
+ """A representation of an asset watcher. The name uniquely identity the
watch."""
+
+ name: str
+ # This attribute serves double purpose. For a "normal" asset instance
+ # loaded from DAG, this holds the trigger used to monitor an external
resource.
+ # For an asset recreated from a serialized DAG, however, this holds the
serialized data of the trigger.
Review Comment:
Are you suggesting we should not use this class when we deserialize the DAG?
Currently this class is used by users when defining their DAGs and by the
scheduler when it deserializes the DAG from the DB. Do you want to use it only
by users? I am trying to understand the path forward :)
Do not we have the same problem with classes like `Asset`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
