vincbeck commented on code in PR #45562:
URL: https://github.com/apache/airflow/pull/45562#discussion_r1932404499
##########
task_sdk/src/airflow/sdk/definitions/asset/__init__.py:
##########
@@ -36,6 +36,7 @@
from sqlalchemy.orm import Session
from airflow.models.asset import AssetModel
+ from airflow.serialization.serialized_objects import SerializedAssetWatcher
Review Comment:
It is under `TYPE_CHECKING`, that should prevent dependency cycles? I am not
familiar with protocols in Python but if you think that'd be better, why not
indeed. But should we do that in another PR? So far there was no dependency
cycles, what makes you think we should have some later?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
