ashb commented on code in PR #45562:
URL: https://github.com/apache/airflow/pull/45562#discussion_r1931986671
##########
task_sdk/src/airflow/sdk/definitions/asset/__init__.py:
##########
@@ -36,6 +36,7 @@
from sqlalchemy.orm import Session
from airflow.models.asset import AssetModel
+ from airflow.serialization.serialized_objects import SerializedAssetWatcher
Review Comment:
Importing this here is going to cause us dependency cycles.
I think instead of importing this class we should define a Protocol and then
`watchers: list[AssetWatcherProtocol]` if we can?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
