bugraoz93 commented on code in PR #48099: URL: https://github.com/apache/airflow/pull/48099#discussion_r2018710378
########## .github/workflows/airflow-distributions-tests.yml: ########## @@ -16,10 +16,14 @@ # under the License. Review Comment: Thanks for the review, Kaxil! It is there. I first created a separate workflow for airflowctl. Then I hit the limitation of Github. The limitation is to have 20 unique workflows in CI. I merged non-core distribution tests with conditional checks. So single workflow is now running both Task SDK and Airflow CTL tests tasks. See: https://github.com/apache/airflow/blob/e79becc882e4424381d44f34013b88f1a355cc8d/.github/workflows/ci.yml#L589-L625 The CI is created with the same workflow. The only difference is that it checks the distribution_name and runs the job steps accordingly. This way, whenever there is be non-core new distribution (other than providers), we can easily add without increasing the # of workflows in the CI. <img width="921" alt="Screenshot 2025-03-28 at 14 34 25" src="https://github.com/user-attachments/assets/911c8831-c743-4f00-83af-1c367502ff5e"; /> Currently, it is impossible to add a new workflow without merging some logic into the CI. :( So what made sense to me is to merge two non-core distributions at the same workflow because their steps are the same for all breeze/CI steps. I don't think we are using the Github workflow file somewhere else. Please correct me if I am missing something -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
