gopidesupavan commented on code in PR #48099:
URL: https://github.com/apache/airflow/pull/48099#discussion_r2019181213
##########
.github/workflows/airflow-distributions-tests.yml:
##########
@@ -16,10 +16,14 @@
# under the License.
Review Comment:
@bugraoz93 you can do something like this to eliminate if conditons:
Workflow call will be like this
```
with:
distribution-name: "Task SDK"
distribution-cmd-format: "prepare-task-sdk-distributions"
test-type: "task-sdk-tests"
```
Inputs will be like this
```
distribution-name:
description: "The name of the distribution to test"
required: true
type: string
distribution-cmd-format:
description: "The type of distribution to test" #eg
prepare-task-sdk-distributions
required: true
type: string
test-type:
description: "distribution test typ" #eg task-sdk-tests
required: true
type: string
```
And finally you pas all the inputs
```
- name: "Prepare Airflow ${{inputs.distribution-name}}: wheel"
env:
DISTRIBUTION_TYPE: "${{ inputs.distribution-cmd-format }}"
run: >
breeze release-management "${DISTRIBUTION_TYPE}"
--distribution-format wheel
- name: "Verify wheel packages with twine"
run: |
uv tool uninstall twine || true
uv tool install twine && twine check dist/*.whl
# Conditional steps based on the distribution name
- name: >
Run unit tests for Airflow ${{inputs.distribution-name}}:Python
${{ matrix.python-version }}
env:
PYTHON_VERSION: "${{ matrix.python-version }}"
TEST_TYPE: "${{ inputs.test-type }}"
run: >
breeze testing "${TEST_TYPE}" --python "${PYTHON_VERSION}"
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
