dheerajturaga commented on code in PR #50425:
URL: https://github.com/apache/airflow/pull/50425#discussion_r2083053821


##########
providers/edge3/src/airflow/providers/edge3/cli/edge_command.py:
##########
@@ -342,7 +344,8 @@ def start(self):
             if e.response.status_code == HTTPStatus.NOT_FOUND:
                 raise SystemExit("Error: API endpoint is not ready, please set 
[edge] api_enabled=True.")
             raise SystemExit(str(e))
-        _write_pid_to_pidfile(self.pid_file_path)
+        if not self.daemon:

Review Comment:
   `run_command_with_daemon_option` likes to create the pid and manage it when 
running a daemonized process. We will let it control the pid creation and 
removal.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to