jscheffl commented on code in PR #50425:
URL: https://github.com/apache/airflow/pull/50425#discussion_r2083139539


##########
providers/edge3/src/airflow/providers/edge3/cli/edge_command.py:
##########
@@ -787,6 +803,13 @@ def remote_worker_request_shutdown(args) -> None:
     help="State of the edge worker",
 )
 
+ARG_DAEMON = Arg(
+    ("-D", "--daemon"), help="Daemonize instead of running in the foreground", 
action="store_true"
+)
+ARG_STDERR = Arg(("--stderr",), help="Redirect stderr to this file")
+ARG_STDOUT = Arg(("--stdout",), help="Redirect stdout to this file")
+ARG_LOG_FILE = Arg(("-l", "--log-file"), help="Location of the log file")

Review Comment:
   What is the difference of `-l` to `--stdout/err`? Is this just a convenience 
that you don't need to set both?
   If these are not given, will stdout/err just be directed to /dev/null?
   Should these options carry a default to make logs into the working directory 
where started?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to