jscheffl commented on code in PR #50425:
URL: https://github.com/apache/airflow/pull/50425#discussion_r2083506636
##########
providers/edge3/src/airflow/providers/edge3/cli/edge_command.py:
##########
@@ -517,12 +517,18 @@ def _launch_worker(args):
@providers_configuration_loaded
def worker(args):
"""Start Airflow Edge Worker."""
+ if args.umask:
+ umask = args.umask
+ else:
+ umask = conf.get("edge", "worker_umask",
fallback=settings.DAEMON_UMASK)
Review Comment:
As you create a new setting, can you also please add this to
`providers/edge3/provider.yaml` including some descriptions?
By the way in Python this if/else can be made shorter as:
```suggestion
umask = args.umask or conf.get("edge", "worker_umask",
fallback=settings.DAEMON_UMASK)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
