jscheffl commented on code in PR #50425:
URL: https://github.com/apache/airflow/pull/50425#discussion_r2083506985
##########
providers/edge3/src/airflow/providers/edge3/cli/edge_command.py:
##########
@@ -787,6 +803,13 @@ def remote_worker_request_shutdown(args) -> None:
help="State of the edge worker",
)
+ARG_DAEMON = Arg(
+ ("-D", "--daemon"), help="Daemonize instead of running in the foreground",
action="store_true"
+)
+ARG_STDERR = Arg(("--stderr",), help="Redirect stderr to this file")
+ARG_STDOUT = Arg(("--stdout",), help="Redirect stdout to this file")
+ARG_LOG_FILE = Arg(("-l", "--log-file"), help="Location of the log file")
Review Comment:
As the parameters are only used when in daemon mode, can you mention this in
the help?
```suggestion
ARG_STDERR = Arg(("--stderr",), help="Redirect stderr to this file if run in
daemon mode")
ARG_STDOUT = Arg(("--stdout",), help="Redirect stdout to this file if run in
daemon mode")
ARG_LOG_FILE = Arg(("-l", "--log-file"), help="Location of the log file if
run in daemon mode")
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
