bbovenzi commented on code in PR #65661:
URL: https://github.com/apache/airflow/pull/65661#discussion_r3131009305
##########
airflow-core/src/airflow/ui/src/pages/TaskInstance/ExtraLinks.tsx:
##########
@@ -36,7 +37,7 @@ const getTarget = (url: string) => {
}
};
-export const ExtraLinks = ({ refetchInterval }: ExtraLinksProps) => {
+export const ExtraLinks = ({ refetchInterval, tryNumber }: ExtraLinksProps) =>
{
Review Comment:
We don't need to drill the tryNumber prop down so many levels. Let's just
check `useSearchParams` and if there is no tryNumber then use undefined
##########
airflow-core/newsfragments/65661.improvement.rst:
##########
@@ -0,0 +1 @@
+Pass try_number to the extra links API so that operator extra links reflect
the correct task attempt when viewing retries.
Review Comment:
No need for a newsfragment
##########
airflow-core/src/airflow/api_fastapi/core_api/routes/public/extra_links.py:
##########
@@ -75,6 +76,9 @@ def get_extra_links(
"TaskInstance not found",
)
+ if try_number is not None:
Review Comment:
Let's put in a comment here saying how we only need the try_number and not
the full task_instance_history entry
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
