pierrejeambrun commented on code in PR #65661:
URL: https://github.com/apache/airflow/pull/65661#discussion_r3131660872
##########
airflow-core/tests/unit/api_fastapi/core_api/routes/public/test_extra_links.py:
##########
@@ -284,6 +297,16 @@ def test_should_respond_200_mapped_task_instance(self,
test_client, session):
).model_dump()
)
+ @pytest.mark.mock_plugin_manager(plugins=[TryNumberPlugin])
+ def test_should_use_try_number_when_specified(self, test_client):
+ """When try_number param is passed, it overrides ti.try_number for
link generation."""
+ response = test_client.get(
+
f"/dags/{self.dag_id}/dagRuns/{self.dag_run_id}/taskInstances/{self.task_single_link}/links",
+ params={"try_number": 3},
+ )
+ assert response.status_code == 200
+ assert response.json()["extra_links"]["Try Number"] ==
"https://example.com/logs?try_number=3";
Review Comment:
Verify the try_number in the db is still the correct one, not `3`.
##########
airflow-core/src/airflow/api_fastapi/core_api/routes/public/extra_links.py:
##########
@@ -75,6 +76,11 @@ def get_extra_links(
"TaskInstance not found",
)
+ if try_number is not None:
+ # We only need to override try_number on the existing TI to generate
+ # attempt-specific links; fetching the full TaskInstanceHistory is
unnecessary.
+ ti.try_number = try_number
Review Comment:
Isn't this persisted into the DB? Session auto-commit on exit. Can you
verify in the tests please.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
