shashbha14 commented on code in PR #65661:
URL: https://github.com/apache/airflow/pull/65661#discussion_r3132909556
##########
airflow-core/src/airflow/api_fastapi/core_api/routes/public/extra_links.py:
##########
@@ -75,6 +76,11 @@ def get_extra_links(
"TaskInstance not found",
)
+ if try_number is not None:
+ # We only need to override try_number on the existing TI to generate
+ # attempt-specific links; fetching the full TaskInstanceHistory is
unnecessary.
+ ti.try_number = try_number
Review Comment:
> Also there is no validation, meaning that you can get 'link' generation
for tries that do not exist in the db. that sounds a little off to me. I would
expect a 404 instead of being able to get links with `try_number=100000`
the route now returns 404 if the requested try_number doesn't exist in
TaskInstanceHistory. Added
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
