shashbha14 commented on code in PR #65661:
URL: https://github.com/apache/airflow/pull/65661#discussion_r3132905603
##########
airflow-core/src/airflow/api_fastapi/core_api/routes/public/extra_links.py:
##########
@@ -75,6 +76,11 @@ def get_extra_links(
"TaskInstance not found",
)
+ if try_number is not None:
+ # We only need to override try_number on the existing TI to generate
+ # attempt-specific links; fetching the full TaskInstanceHistory is
unnecessary.
+ ti.try_number = try_number
Review Comment:
> Isn't this persisted into the DB? Session auto-commit on exit. Can you
verify in the tests please.
Fixed this and replaced the session.expunge + patching approach with
fetching TaskInstanceHistory directly. The live TI is never modified.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
