gtristan commented on code in PR #1903:
URL: https://github.com/apache/buildstream/pull/1903#discussion_r1539309091
##########
src/buildstream/_pluginfactory/sourcemirrorfactory.py:
##########
@@ -62,9 +62,9 @@ def create(self, context: "Context", project: "Project",
node: MappingNode) -> S
#
kind = node.get_str("kind", None)
if kind is None:
- plugin_type = SourceMirror
- else:
- plugin_type, _ = self.lookup(context.messenger, kind, node)
+ kind = "legacy"
Review Comment:
I see what you're doing here, by making the default way of handling source
mirrors a subclass of the base class instead of the base class.
I agree with this logic but I would not like to call it _"legacy"_, as that
implies that it is old and unused, maybe we could call it _"default"_ or
similar.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
